Add protocol version auto-update workflow - #978
Open
leighmcculloch wants to merge 24 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds daily automation to calculate and update each image’s default protocol version from resolved component sources.
Changes:
- Adds protocol-version extraction and update logic.
- Adds a scheduled workflow that opens auto-merging update PRs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.scripts/auto-update-protocol-version |
Calculates protocol defaults from component sources. |
.github/workflows/auto-update-protocol-version.yml |
Runs updates daily and creates PRs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+140
to
+141
| majors = [int(m) for m in re.findall(r"core_deb_version:\s*['\"]?(\d+)", text)] | ||
| return max(majors, default=None) |
Comment on lines
+80
to
+86
| if not dep: | ||
| print(f"{tag}: skipping, no '{name}' dep") | ||
| return False | ||
| version = extract(dep) | ||
| if version is None: | ||
| print(f"{tag}: skipping, could not read protocol version from {name} ({dep['repo']}@{dep['ref']})") | ||
| return False |
fnando
approved these changes
Aug 27, 2026
|
|
||
| on: | ||
| schedule: | ||
| - cron: '30 1 * * *' # 5:30 PM Pacific |
Member
There was a problem hiding this comment.
This wouldn't be true depending on PDT/PST, but meh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A daily workflow that sets each image's
protocol_version_defaultto the highest protocol supported by all of its xdr, core, rpc, and horizon components — read from each component's source at the resolved commit — and opens an auto-merging PR when the value changes.Why
Maintainers had to keep
protocol_version_defaultin sync with the components' max supported protocol by hand, which is error-prone and drifts out of date (#860).Close #860